This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Reposition Brave Lion on Windows #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5069 (Refine the Brave button (look, positioning, feel) on Windows) Fixes #5383 (Brave Logo Slides Beneath URL Bar) Also includes (no issue): Hide extra drag area when menu is showing Auditors: @jonathansampson, @bbondy Test Plan (required for Windows 10 and Windows 7) 1. Launch Brave 2. Have menu hidden and always show URL bar to true 3. Lion should have an extra separator next to the right of it and caption buttons should be center aligned. Compare against mockup. 4. Make window really skinny (width-wise) 5. Brave lion or extension icons should NOT go under URL bar 6. Disable "auto-hide menu" so that menu is always showing 7. Lion should now be under the caption buttons and there should be no grab area to the left of it (except for where the noscript icon goes, but that wasn't changed and isn't draggable)
|
++ @jonathansampson could you give it a try? |
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixes #5069 (Refine the Brave button (look, positioning, feel) on Windows)
Fixes #5383 (Brave Logo Slides Beneath URL Bar)
edit:
Fixes #5145 (Window buttons not properly aligned when browser is maximized)
Also includes (no issue):
Hide extra drag area when menu is showing
NOTE: I've only manually tested on Windows 10. Still needs to be manually tested on Windows 7 before being accepted. Any help there is appreciated 😄
Auditors: @jonathansampson, @bbondy
Test Plan
should be executed on Windows 10 and Windows 7
buttons should be center aligned. Compare against mockup.
grab area to the left of it (except for where the noscript icon goes, but
that wasn't changed and isn't draggable)
screenshots